]> code.ossystems Code Review - openembedded-core.git/commitdiff
run-postinsts: Fix full execution of scripts at first boot
authorAlejandro Enedino Hernandez Samaniego <alejandr@xilinx.com>
Wed, 8 May 2019 19:04:01 +0000 (12:04 -0700)
committerArmin Kuster <akuster808@gmail.com>
Sat, 1 Jun 2019 21:48:32 +0000 (14:48 -0700)
run-postinsts runs a given set of scripts during the first boot of the
device, when one of these scripts prints something to stdout (isnt
daemonized correctly), since stdout is not available at that time,
the script execution immediately returns with an error (exit_group()),
this error causes the script to terminate all threads within the process,
causing undesired behavior since the script might still had to execute
some other code.

Replace eval built-in with (), since () executes in a subshell,
even if one of the scripts exits, all threads of that process will only
be within that session, this ensures other scripts meant to be run are
still run afterwards.

[YOCTO #13266]

Signed-off-by: Alejandro Enedino Hernandez Samaniego <alejandr@xilinx.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
meta/recipes-devtools/run-postinsts/run-postinsts/run-postinsts

index 95eff04e17ee663cf53ba0ced54317559b1b10b2..f84a7e18c8301405b1a36bd279cfae744afbbc74 100755 (executable)
@@ -67,7 +67,7 @@ exec_postinst_scriptlets() {
                echo "Running postinst $i..."
                [ "$POSTINST_LOGGING" = "1" ] && eval echo "Running postinst $i..." $append_log
                if [ -x $i ]; then
-                       eval sh -c $i $append_log
+                       (sh -c $i $append_log)
                        rm $i
                else
                        echo "ERROR: postinst $i failed."