]> code.ossystems Code Review - meta-freescale.git/commitdiff
image_types_fsl.bbclass: use dd's option fsync instead of sync
authorStefan Christ <s.christ@phytec.de>
Tue, 5 May 2015 08:40:08 +0000 (10:40 +0200)
committerOtavio Salvador <otavio@ossystems.com.br>
Mon, 11 May 2015 13:20:01 +0000 (10:20 -0300)
The shell command sync flushes all filesystem buffers in the system.  On
a bigger multiuser system there are multiple gigs of data sometimes in
the buffer which then are written out to disk at once.  It's better to
only flush the specific file with dd's option 'fsync'.

Change-Id: I6476444dbbc28e4f8756066e531734ef1de71fdb
Signed-off-by: Stefan Christ <s.christ@phytec.de>
Tested-by: Nikolay Dimitrov <picmaster@mail.bg>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
meta-fsl-arm/classes/image_types_fsl.bbclass

index 75eca59f81dca5978f9b33a2774a33117a3ef448..1ebcb0637d0e87174125b5bea478c28225d26ba3 100644 (file)
@@ -178,8 +178,8 @@ generate_imx_sdcard () {
        fi
 
        # Burn Partition
-       dd if=${WORKDIR}/boot.img of=${SDCARD} conv=notrunc seek=1 bs=$(expr ${IMAGE_ROOTFS_ALIGNMENT} \* 1024) && sync && sync
-       dd if=${SDCARD_ROOTFS} of=${SDCARD} conv=notrunc seek=1 bs=$(expr ${BOOT_SPACE_ALIGNED} \* 1024 + ${IMAGE_ROOTFS_ALIGNMENT} \* 1024) && sync && sync
+       dd if=${WORKDIR}/boot.img of=${SDCARD} conv=notrunc,fsync seek=1 bs=$(expr ${IMAGE_ROOTFS_ALIGNMENT} \* 1024)
+       dd if=${SDCARD_ROOTFS} of=${SDCARD} conv=notrunc,fsync seek=1 bs=$(expr ${BOOT_SPACE_ALIGNED} \* 1024 + ${IMAGE_ROOTFS_ALIGNMENT} \* 1024)
 }
 
 #
@@ -293,7 +293,7 @@ generate_mxs_sdcard () {
 
        parted ${SDCARD} print
 
-       dd if=${SDCARD_ROOTFS} of=${SDCARD} conv=notrunc seek=1 bs=$(expr ${BOOT_SPACE_ALIGNED} \* 1024 + ${IMAGE_ROOTFS_ALIGNMENT} \* 1024) && sync && sync
+       dd if=${SDCARD_ROOTFS} of=${SDCARD} conv=notrunc,fsync seek=1 bs=$(expr ${BOOT_SPACE_ALIGNED} \* 1024 + ${IMAGE_ROOTFS_ALIGNMENT} \* 1024)
 }
 
 IMAGE_CMD_sdcard () {