]> code.ossystems Code Review - openembedded-core.git/commitdiff
grub2: Enable on riscv32
authorKhem Raj <raj.khem@gmail.com>
Mon, 29 Mar 2021 02:22:09 +0000 (19:22 -0700)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 30 Mar 2021 23:05:43 +0000 (00:05 +0100)
Update the patch as submitted upstream to grub2

Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-bsp/grub/files/0001-RISC-V-Restore-the-typcast-to-long.patch
meta/recipes-bsp/grub/grub2.inc

index f0ffb3d9549d34e4605f08d086dcde51682bc0ba..2f15a91f684689c1771bde66140d33be24f638bb 100644 (file)
@@ -1,18 +1,28 @@
-From bf248231cb4f9f966f0d57821dd0491af54d4a0b Mon Sep 17 00:00:00 2001
+From e4c41db74b8972285cbdfe614c95c1ffd97d70e1 Mon Sep 17 00:00:00 2001
 From: Khem Raj <raj.khem@gmail.com>
 Date: Fri, 26 Mar 2021 11:59:43 -0700
-Subject: [PATCH] RISC-V: Restore the typcast to long
+Subject: [PATCH] RISC-V: Restore the typcast to 64bit type
 
 this makes the type promotions clear and explicit
+It was already typecasted to long but was accidentally dropped in [1]
+which stated to cause failures on riscv32 as reported in [2]
 
-Upstream-Status: Pending
+[1] https://git.savannah.gnu.org/cgit/grub.git/commit/?id=2bf40e9e5be9808b17852e688eead87acff14420
+[2] https://savannah.gnu.org/bugs/index.php?60283
+
+Upstream-Status: Submitted
 Signed-off-by: Khem Raj <raj.khem@gmail.com>
+Cc: Andreas Schwab <schwab@suse.de>
+Cc: Daniel Kiper <daniel.kiper@oracle.com>
+Cc: Chester Lin <clin@suse.com>
+Cc: Nikita Ermakov <arei@altlinux.org>
+Cc: Alistair Francis <alistair.francis@wdc.com>
 ---
  util/grub-mkimagexx.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/util/grub-mkimagexx.c b/util/grub-mkimagexx.c
-index 00f49cc..ab5523d 100644
+index 00f49ccaa..ac677d03d 100644
 --- a/util/grub-mkimagexx.c
 +++ b/util/grub-mkimagexx.c
 @@ -1242,7 +1242,7 @@ SUFFIX (relocate_addrs) (Elf_Ehdr *e, struct section_metadata *smd,
@@ -20,10 +30,10 @@ index 00f49cc..ab5523d 100644
  
                 sym_addr += addend;
 -               off = sym_addr - target_section_addr - offset - image_target->vaddr_offset;
-+               off = (long)sym_addr - target_section_addr - offset - image_target->vaddr_offset;
++               off = (grub_int64_t)sym_addr - target_section_addr - offset - image_target->vaddr_offset;
  
                 switch (ELF_R_TYPE (info))
                   {
 -- 
-2.31.0
+2.31.1
 
index 0e431ac008c73af702907fa4bb5d6332c97ed2f0..590deb8d9262a6bd6ba982d8cac1182cc6db8acf 100644 (file)
@@ -34,7 +34,7 @@ UPSTREAM_CHECK_REGEX = "grub-(?P<pver>\d+(\.\d+)+)\.tar\.(gz|xz)"
 
 DEPENDS = "flex-native bison-native gettext-native"
 
-COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|aarch64.*|riscv64)-(linux.*|freebsd.*)'
+COMPATIBLE_HOST = '(x86_64.*|i.86.*|arm.*|aarch64.*|riscv.*)-(linux.*|freebsd.*)'
 COMPATIBLE_HOST_armv7a = 'null'
 COMPATIBLE_HOST_armv7ve = 'null'