gstreamer1.0-plugins-good: fix qtdemux_parse_svq3_stsd_data() memory leak

Backport from 1.11.1

  https://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=29433495d697e4dcb3bc50ff0e0d866acb949890

Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good/qtdemux-free-seqh-after-calling-qtdemux_parse_svq3_s.patch b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good/qtdemux-free-seqh-after-calling-qtdemux_parse_svq3_s.patch
new file mode 100644 (file)
index 0000000..3428790
--- /dev/null
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good/qtdemux-free-seqh-after-calling-qtdemux_parse_svq3_s.patch
@@ -0,0 +1,33 @@
+From 29433495d697e4dcb3bc50ff0e0d866acb949890 Mon Sep 17 00:00:00 2001
+From: Andre McCurdy <armccurdy@gmail.com>
+Date: Wed, 11 Jan 2017 17:53:32 -0800
+Subject: [PATCH] qtdemux: free seqh after calling
+ qtdemux_parse_svq3_stsd_data()
+
+The seqh buffer allocated in qtdemux_parse_svq3_stsd_data() needs to
+be freed by the caller after use.
+
+https://bugzilla.gnome.org/show_bug.cgi?id=777157
+
+Upstream-Status: Backport
+
+Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
+---
+ gst/isomp4/qtdemux.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/gst/isomp4/qtdemux.c b/gst/isomp4/qtdemux.c
+index e105809..7a431e0 100644
+--- a/gst/isomp4/qtdemux.c
++++ b/gst/isomp4/qtdemux.c
+@@ -10375,6 +10375,7 @@ qtdemux_parse_trak (GstQTDemux * qtdemux, GNode * trak)
+              * than its own fourcc */
+             gst_caps_set_simple (stream->caps, "seqh", GST_TYPE_BUFFER, seqh,
+                 NULL);
++            gst_buffer_unref (seqh);
+           }
+ 
+           GST_DEBUG_OBJECT (qtdemux, "found codec_data in stsd");
+-- 
+1.9.1
+

diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.10.2.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.10.2.bb
index 18262d0bfdce56b5031f49adf517d8b553f26c95..6c119e5c769530e3c2f10807d81c81ce23a19d38 100644 (file)
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.10.2.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.10.2.bb
@@ -10,6 +10,7 @@ SRC_URI = " \
     file://avoid-including-sys-poll.h-directly.patch \
     file://ensure-valid-sentinel-for-gst_structure_get.patch \
     file://0001-introspection.m4-prefix-pkgconfig-paths-with-PKG_CON.patch \
+    file://qtdemux-free-seqh-after-calling-qtdemux_parse_svq3_s.patch \
 "
 SRC_URI[md5sum] = "65c4ff9d406c3ea9383b4d38a6504349"
 SRC_URI[sha256sum] = "198f325bcce982dce1ebeb36929a5f430b8bf9528e0d519e18df0b29e1d23313"