]> code.ossystems Code Review - openembedded-core.git/commitdiff
Fix comparison with SRCREVINACTION constant
authorJavier Martin <javier.martin@vista-silicon.com>
Thu, 27 Jan 2011 08:38:21 +0000 (09:38 +0100)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 10 Feb 2011 22:35:28 +0000 (22:35 +0000)
Use '==' instead of 'is', otherwise it will always return
true since 'rev' and "SRCREVINACTION" are not the same object.

(Bitbake rev: f30b3af975a071d1584817054a2996f08a3aba4f)

Signed-off-by: Javier Martin <javier.martin@vista-silicon.com>
Signed-off-by: Chris Larson <chris_larson@mentor.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
bitbake/lib/bb/fetch/__init__.py

index b452751c7b24ca7651e30c40ede39ae76474ed67..65b4da07da58a0e3dfec11e43b794a5933382dfc 100644 (file)
@@ -704,7 +704,7 @@ class Fetch(object):
             raise InvalidSRCREV("Please set SRCREV to a valid value")
         if not rev:
             return False
-        if rev is "SRCREVINACTION":
+        if rev == "SRCREVINACTION":
             return True
         return rev