]> code.ossystems Code Review - openembedded-core.git/commitdiff
insane.bbclass: validate desktop files
authorRoss Burton <ross@openedhand.com>
Wed, 14 Nov 2007 09:36:55 +0000 (09:36 +0000)
committerRoss Burton <ross@openedhand.com>
Wed, 14 Nov 2007 09:36:55 +0000 (09:36 +0000)
git-svn-id: https://svn.o-hand.com/repos/poky/trunk@3151 311d38ba-8fff-0310-9ca6-ca027cbcb966

meta/classes/insane.bbclass

index 613d0e57a8471420ce8ea402092ced1fbf6f0472..7b7175232d884999d07580277e30810ee72a52e0 100644 (file)
@@ -21,7 +21,7 @@
 
 # We play a special package function
 inherit package
-PACKAGE_DEPENDS += "pax-utils-native"
+PACKAGE_DEPENDS += "pax-utils-native desktop-file-utils-native"
 #PACKAGE_DEPENDS += chrpath-native"
 PACKAGEFUNCS += " do_package_qa "
 
@@ -308,8 +308,19 @@ def package_qa_check_pcla(path,name,d):
     .pc and .la files should not point to the WORKDIR
     """
     sane = True
+    # TODO
     return sane
 
+def package_qa_check_desktop(path, name, d):
+    """
+    Run all desktop files through desktop-file-validate.
+    """
+    import bb, os
+    if path.endswith(".desktop"):
+        validate = os.path.join(bb.data.getVar('STAGING_BINDIR_NATIVE',d,True), 'desktop-file-validate')
+        os.system ("%s %s" % (validate, path))
+    return True
+
 def package_qa_check_staged(path,d):
     """
     Check staged la and pc files for sanity
@@ -422,7 +433,7 @@ python do_package_qa () {
 
         bb.note("Checking Package: %s" % package)
         path = "%s/install/%s" % (workdir, package)
-        if not package_qa_walk(path, [package_qa_check_rpath, package_qa_check_devdbg, package_qa_check_perm, package_qa_check_arch], package, d):
+        if not package_qa_walk(path, [package_qa_check_rpath, package_qa_check_devdbg, package_qa_check_perm, package_qa_check_arch, package_qa_check_desktop], package, d):
             walk_sane  = False
         if not package_qa_check_rdepends(package, workdir, d):
             rdepends_sane = False