]> code.ossystems Code Review - openembedded-core.git/commitdiff
bitbake.conf: fix distro-less failure expanding FILESPATH
authorDenys Dmytriyenko <denys@ti.com>
Thu, 22 Mar 2012 01:33:03 +0000 (21:33 -0400)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 22 Mar 2012 16:41:28 +0000 (16:41 +0000)
If DISTRO is not set, FILESPATH becomes littered with directories like
files/${DISTRO} etc. It won't bomb until you try to eval it - i.e.
manipulating FILESPATH directly with .= works fine, but calling e.g.
base_set_filespath() throws this:

ERROR: Failure expanding variable FILESPATH, expression was ${@blah} which
triggered exception SyntaxError: EOL while scanning string literal (FILESPATH,
line 1)

Signed-off-by: Denys Dmytriyenko <denys@ti.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/conf/bitbake.conf

index 07982d783d8908da35f8cb32ad78d17bcd78b963..a9fcf052c3e7a75dd7df39cc945bf4798f3860a5 100644 (file)
@@ -638,7 +638,7 @@ AUTO_LIBNAME_PKGS = "${PACKAGES}"
 # This works for  functions as well, they are really just environment variables.
 # Default OVERRIDES to make compilation fail fast in case of build system misconfiguration.
 OVERRIDES = "${TARGET_OS}:${TRANSLATED_TARGET_ARCH}:build-${BUILD_OS}:pn-${PN}:${MACHINEOVERRIDES}:${DISTROOVERRIDES}:forcevariable"
-DISTROOVERRIDES ?= "${DISTRO}"
+DISTROOVERRIDES ?= "${@d.getVar('DISTRO', True) or ''}"
 MACHINEOVERRIDES ?= "${MACHINE}"
 MACHINEOVERRIDES[vardepsexclude] = "MACHINE"