]> code.ossystems Code Review - openembedded-core.git/commitdiff
package_manager.py: Allow a leading - in PACKAGE_EXCLUDE_COMPLEMENTARY
authorPeter Kjellerstedt <peter.kjellerstedt@axis.com>
Wed, 5 Oct 2016 15:30:45 +0000 (17:30 +0200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 5 Oct 2016 22:22:33 +0000 (23:22 +0100)
This allows a regular expression specified in
PACKAGE_EXCLUDE_COMPLEMENTARY to have a leading dash. Without this,
the dash was treated by oe-pkgdata-util as the beginning of a command
line argument. E.g., if PACKAGE_EXCLUDE_COMPLEMENTARY = "-foo$", it
resulted in an error like:

  ERROR: <imagename>-1.0-r0 do_populate_sdk: Could not compute
  complementary packages list. Command '<topdir>/scripts/oe-pkgdata-util -p
  <builddir>/tmp/sysroots/<machine>/pkgdata glob
  <workdir>/installed_pkgs.txt *-dev *-dbg -x -foo$' returned 2:
  ERROR: argument -x/--exclude: expected one argument
  usage: oe-pkgdata-util glob [-h] [-x EXCLUDE] pkglistfile glob [glob ...]

Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/lib/oe/package_manager.py

index 434b898d3d8b8a9d8ac30affe576abdb72bb5a58..5f86affab2917e283e75610f679b7664db90a8a7 100644 (file)
@@ -598,7 +598,7 @@ class PackageManager(object, metaclass=ABCMeta):
                globs]
         exclude = self.d.getVar('PACKAGE_EXCLUDE_COMPLEMENTARY', True)
         if exclude:
-            cmd.extend(['-x', exclude])
+            cmd.extend(['--exclude=' + exclude])
         try:
             bb.note("Installing complementary packages ...")
             bb.note('Running %s' % cmd)