]> code.ossystems Code Review - openembedded-core.git/commitdiff
oe-buildenv-internal: simplify derivation of BB_ENV_EXTRAWHITE
authorAndre McCurdy <armccurdy@gmail.com>
Thu, 24 Mar 2016 17:49:22 +0000 (10:49 -0700)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sat, 26 Mar 2016 22:49:36 +0000 (22:49 +0000)
Use 'sort --unique' to combine the two lists and remove duplicates.

Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
scripts/oe-buildenv-internal

index 8eee0087a9806aa3bbec66a6fac9853393f79bfd..be212f2cd0184857483fd58e052191af54668c02 100755 (executable)
@@ -110,29 +110,12 @@ unset BITBAKEDIR newpath
 export BUILDDIR
 export PATH
 
-add_extrawhite() {
-    # If the current shell is zsh, then temporarily set it to emulate sh in this
-    # function so that the for and case statements below work as expected.
-    [ -z "$ZSH_NAME" ] || emulate -L sh
-
-    local extrawhite="MACHINE DISTRO TCMODE TCLIBC HTTP_PROXY http_proxy \
+BB_ENV_EXTRAWHITE_OE="MACHINE DISTRO TCMODE TCLIBC HTTP_PROXY http_proxy \
 HTTPS_PROXY https_proxy FTP_PROXY ftp_proxy FTPS_PROXY ftps_proxy ALL_PROXY \
 all_proxy NO_PROXY no_proxy SSH_AGENT_PID SSH_AUTH_SOCK BB_SRCREV_POLICY \
 SDKMACHINE BB_NUMBER_THREADS BB_NO_NETWORK PARALLEL_MAKE GIT_PROXY_COMMAND \
 SOCKS5_PASSWD SOCKS5_USER SCREENDIR STAMPS_DIR"
 
-    local var
-    for var in $extrawhite; do
-        case " $BB_ENV_EXTRAWHITE " in
-            *[[:blank:]]$var[[:blank:]]*)
-                ;;
-            *)
-                BB_ENV_EXTRAWHITE="${BB_ENV_EXTRAWHITE:+$BB_ENV_EXTRAWHITE }$var"
-                ;;
-        esac
-    done
-}
-
-add_extrawhite
-unset -f add_extrawhite
+BB_ENV_EXTRAWHITE=$(echo $BB_ENV_EXTRAWHITE $BB_ENV_EXTRAWHITE_OE | sed 's/ /\n/g' | LC_ALL=C sort --unique)
+
 export BB_ENV_EXTRAWHITE