]> code.ossystems Code Review - openembedded-core.git/commitdiff
ldconfig-native: fix a endian-ness bug
authorShan Hai <shan.hai@windriver.com>
Fri, 24 Oct 2014 06:05:36 +0000 (14:05 +0800)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 4 Nov 2014 10:19:55 +0000 (10:19 +0000)
Some header fields of ELF were read with wrong size on 64bit
big-endian machine, fix it by reading the fields with read64
instead of read32.

Signed-off-by: Par Olsson <Par.Olsson@windriver.com>
Signed-off-by: Shan Hai <shan.hai@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
meta/recipes-core/glibc/ldconfig-native-2.12.1/endian-ness_handling_fix.patch [new file with mode: 0644]
meta/recipes-core/glibc/ldconfig-native_2.12.1.bb

diff --git a/meta/recipes-core/glibc/ldconfig-native-2.12.1/endian-ness_handling_fix.patch b/meta/recipes-core/glibc/ldconfig-native-2.12.1/endian-ness_handling_fix.patch
new file mode 100644 (file)
index 0000000..6aecfe5
--- /dev/null
@@ -0,0 +1,47 @@
+Upstream-Status: Inappropriate [embedded specific]
+
+Fix problem during parsing of ELF headers for 64bit on big-endian.
+Some header fields were read with wrong size.
+
+2014/10/24
+Par Olsson <Par.Olsson@windriver.com>
+Shan Hai <shan.hai@windriver.com>
+
+diff --git a/readelflib.c b/readelflib.c
+index 3f5b25b..0bf0de3 100644
+--- a/readelflib.c
++++ b/readelflib.c
+@@ -261,8 +261,8 @@ process_elf_file64 (const char *file_name, const char *lib, int *flag,
+   int i;
+   unsigned int j;
+   Elf64_Addr loadaddr;
+-  unsigned int dynamic_addr;
+-  size_t dynamic_size;
++  Elf64_Addr dynamic_addr;
++  Elf64_Xword dynamic_size;
+   char *program_interpreter;
+   Elf64_Ehdr *elf_header;
+@@ -311,7 +311,7 @@ process_elf_file64 (const char *file_name, const char *lib, int *flag,
+           error (0, 0, _("more than one dynamic segment\n"));
+         dynamic_addr = read64(segment->p_offset, be);
+-        dynamic_size = read32(segment->p_filesz, be);
++        dynamic_size = read64(segment->p_filesz, be);
+         break;
+       case PT_INTERP:
+@@ -329,11 +329,11 @@ process_elf_file64 (const char *file_name, const char *lib, int *flag,
+         break;
+       case PT_NOTE:
+-        if (!*osversion && read32(segment->p_filesz, be) >= 32 && read32(segment->p_align, be) >= 4)
++        if (!*osversion && read64(segment->p_filesz, be) >= 32 && read64(segment->p_align, be) >= 4)
+           {
+             Elf64_Word *abi_note = (Elf64_Word *) (file_contents
+                                                    + read64(segment->p_offset, be));
+-            Elf64_Addr size = read32(segment->p_filesz, be);
++            Elf64_Xword size = read64(segment->p_filesz, be);
+             while (read32(abi_note [0], be) != 4 || read32(abi_note [1], be) != 16
+                    || read32(abi_note [2], be) != 1
index 7c3463589b420cc652d5ec768db57730b1a3ef8f..1debf8ee2f4fd96c6ff3dae7f0f8c2636b32343b 100644 (file)
@@ -12,6 +12,7 @@ SRC_URI = "file://ldconfig-native-2.12.1.tar.bz2 \
            file://flag_fix.patch \
            file://endianess-header.patch \
            file://ldconfig-default-to-all-multilib-dirs.patch \
+           file://endian-ness_handling_fix.patch \
 "
 
 PR = "r2"