]> code.ossystems Code Review - openembedded-core.git/commitdiff
scripts: python3: decode subprocess output
authorEd Bartosh <ed.bartosh@linux.intel.com>
Thu, 2 Jun 2016 10:13:00 +0000 (13:13 +0300)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 2 Jun 2016 10:49:50 +0000 (11:49 +0100)
stdeout and stderr content returned by subprocess API has different
types in Python 3(bytes) and Python 2(string). Decoding it to
'utf-8' makes it unicode on both pythons.

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
scripts/cleanup-workdir
scripts/combo-layer
scripts/oe-selftest

index fee464c31df581bcde819616f0fe9caeb288ce08..0b2cf99d78552fcebce049489a795f91f7b1036d 100755 (executable)
@@ -45,7 +45,7 @@ def run_command(cmd):
     if pipe.returncode != 0:
         print("Execute command '%s' failed." % cmd)
         sys.exit(1)
-    return output
+    return output.decode('utf-8')
 
 def get_cur_arch_dirs(workdir, arch_dirs):
     pattern = workdir + '/(.*?)/'
index 36a8f5fa1e62536bd4bc765ce7cb979590fadf6b..eaa7f5adb87e6e687515bd5b3b713b3910354607 100755 (executable)
@@ -198,7 +198,7 @@ def runcmd(cmd,destdir=None,printerr=True,out=None,env=None):
         raise e
 
     err.seek(0)
-    output = err.read()
+    output = err.read().decode('utf-8')
     logger.debug("output: %s" % output.replace(chr(0), '\\0'))
     return output
 
index b1ecf7f32295ed43b6b1137f6588104753469c42..df76f94f7a03a46eb54df3a9a43dff823de0ff86 100755 (executable)
@@ -371,7 +371,7 @@ def coverage_setup(coverage_source, coverage_include, coverage_omit):
     import subprocess
     builddir = os.environ.get("BUILDDIR")
     pokydir = os.path.dirname(os.path.dirname(os.path.realpath(__file__)))
-    curcommit= subprocess.check_output(["git", "--git-dir", os.path.join(pokydir, ".git"), "rev-parse", "HEAD"])
+    curcommit= subprocess.check_output(["git", "--git-dir", os.path.join(pokydir, ".git"), "rev-parse", "HEAD"]).decode('utf-8')
     coveragerc = "%s/.coveragerc" % builddir
     data_file = "%s/.coverage." % builddir
     data_file += datetime.datetime.now().strftime('%Y%m%dT%H%M%S')