]> code.ossystems Code Review - openembedded-core.git/commitdiff
dhcp/ruby/ffpmeg: Use CFLAGS, not TARGET_CFLAGS
authorRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 3 Jul 2019 09:41:57 +0000 (10:41 +0100)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 7 Nov 2019 11:45:25 +0000 (11:45 +0000)
There isn't anything specific about the target in these cases an in
general recipes should touch CFLAGS. This ensures people don't
copy/paste bad example usages. In reality, behaviour is mostly
unchanged.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-connectivity/dhcp/dhcp.inc
meta/recipes-devtools/ruby/ruby.inc
meta/recipes-multimedia/ffmpeg/ffmpeg_4.2.1.bb

index 18bbaf884125babd2a04823cf5b63884593df697..c4697beaf1bad14ac7249198ef1585156fc51f56 100644 (file)
@@ -43,7 +43,7 @@ INITSCRIPT_PACKAGES = "dhcp-server"
 INITSCRIPT_NAME_dhcp-server = "dhcp-server"
 INITSCRIPT_PARAMS_dhcp-server = "defaults"
 
-TARGET_CFLAGS += "-D_GNU_SOURCE"
+CFLAGS += "-D_GNU_SOURCE"
 EXTRA_OECONF = "--with-srv-lease-file=${localstatedir}/lib/dhcp/dhcpd.leases \
                 --with-srv6-lease-file=${localstatedir}/lib/dhcp/dhcpd6.leases \
                 --with-cli-lease-file=${localstatedir}/lib/dhcp/dhclient.leases \
index c0ceb1c10b9f9d54648ca7ba97056ed0994cfe0e..ce1b02f012d1694935e14d29cf35a4f5eeb8f664 100644 (file)
@@ -35,6 +35,6 @@ inherit autotools ptest
 # built.
 
 do_configure_prepend() {
-    sed -i "s#%%TARGET_CFLAGS%%#$TARGET_CFLAGS#; s#%%TARGET_LDFLAGS%%#$TARGET_LDFLAGS#" ${S}/common.mk
+    sed -i "s#%%TARGET_CFLAGS%%#$CFLAGS#; s#%%TARGET_LDFLAGS%%#$LDFLAGS#" ${S}/common.mk
     rm -rf ${S}/ruby/
 }
index ec306afaaa04339158be52a98408577dd90cd617..5ac18ba3f1a307faf18712a2b2880561671791b3 100644 (file)
@@ -102,8 +102,8 @@ EXTRA_OECONF = " \
     --arch=${TARGET_ARCH} \
     --target-os="linux" \
     --enable-cross-compile \
-    --extra-cflags="${TARGET_CFLAGS} ${HOST_CC_ARCH}${TOOLCHAIN_OPTIONS}" \
-    --extra-ldflags="${TARGET_LDFLAGS}" \
+    --extra-cflags="${CFLAGS} ${HOST_CC_ARCH}${TOOLCHAIN_OPTIONS}" \
+    --extra-ldflags="${LDFLAGS}" \
     --sysroot="${STAGING_DIR_TARGET}" \
     ${EXTRA_FFCONF} \
     --libdir=${libdir} \