]> code.ossystems Code Review - openembedded-core.git/commitdiff
sqlite3: make CFLAGS consistent across native, nativesdk and target cases
authorAndre McCurdy <armccurdy@gmail.com>
Fri, 23 Aug 2019 20:51:43 +0000 (13:51 -0700)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 27 Aug 2019 21:52:41 +0000 (22:52 +0100)
The previous simplification:

  https://git.openembedded.org/openembedded-core/commit/?id=604777acfc54d285f315b622bd147ed02d55d6fd

looked OK but didn't actually work as expected. The native and
nativesdk classes re-set CFLAGS after the += has been applied and
so any modifications made via += are lost. Use _append instead.

Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-support/sqlite/sqlite3.inc

index 7cf23d04470e24759de0651ccbcddf1359f80d61..044af5ee979693041e34bf9095fb58123a64dace 100644 (file)
@@ -47,10 +47,10 @@ EXTRA_OECONF = " \
 CFLAGS_append = " -fPIC"
 
 # pread() is in POSIX.1-2001 so any reasonable system must surely support it
-CFLAGS += "-DUSE_PREAD"
+CFLAGS_append = " -DUSE_PREAD"
 
 # Provide column meta-data API
-CFLAGS += "-DSQLITE_ENABLE_COLUMN_METADATA"
+CFLAGS_append = " -DSQLITE_ENABLE_COLUMN_METADATA"
 
 PACKAGES = "lib${BPN} lib${BPN}-dev lib${BPN}-doc ${PN}-dbg lib${BPN}-staticdev ${PN}"