]> code.ossystems Code Review - openembedded-core.git/commitdiff
insane: handle recursive configures when checking for unknown configure options
authorRoss Burton <ross.burton@intel.com>
Tue, 10 Dec 2013 19:38:26 +0000 (19:38 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Mon, 16 Dec 2013 12:12:40 +0000 (12:12 +0000)
Some recipes have configure scripts that recursively call other configure
scripts (e.g. dropbear).  These multiple-line matches were not being handled
correctly, so iterate over every matching line instead of assuming only one line
was found.

[ YOCTO #5646 ]

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/insane.bbclass

index a51f504f20530fbbcf806a586df148c8faea888d..e77e9933259fc1b5a539a5869272a93cfb461854 100644 (file)
@@ -941,8 +941,10 @@ Missing inherit gettext?""" % (gt, config))
         try:
             flag = "WARNING: unrecognized options:"
             log = os.path.join(d.getVar('B', True), 'config.log')
-            output = subprocess.check_output(['grep', '-F', flag, log])
-            options = set(map(lambda s: s.strip(' ,'), output.partition(flag)[2].split()))
+            output = subprocess.check_output(['grep', '-F', flag, log]).replace(', ', ' ')
+            options = set()
+            for line in output.splitlines():
+                options |= set(line.partition(flag)[2].split())
             whitelist = set(d.getVar("UNKNOWN_CONFIGURE_WHITELIST", True).split())
             options -= whitelist
             if options: