]> code.ossystems Code Review - openembedded-core.git/commitdiff
net-tools: correctly set COPTS and LOPTS
authorJoe Slater <jslater@windriver.com>
Tue, 14 Nov 2017 21:53:28 +0000 (13:53 -0800)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Mon, 4 Dec 2017 17:14:33 +0000 (17:14 +0000)
COPTS will be ignored if it is defined in the environment.
It must be passed directly to make.  To be consistent, we
pass LOPTS that way, too.

Signed-off-by: Joe Slater <jslater@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
(cherry picked from commit dede6d3d37aab72ae897c3709d21108fa75f6673)
Signed-off-by: Armin Kuster <akuster808@gmail.com>
meta/recipes-extended/net-tools/net-tools_1.60-26.bb

index c23d53376a940d453c410d9a29f66fe783d3523b..69c9af317daf2b197fc8aa2e07e0b2b148f221f3 100644 (file)
@@ -81,20 +81,12 @@ do_configure() {
 
 do_compile() {
        # net-tools use COPTS/LOPTS to allow adding custom options
-       export COPTS="$CFLAGS"
-       export LOPTS="$LDFLAGS"
-       unset CFLAGS
-       unset LDFLAGS
-
-       oe_runmake
+       oe_runmake COPTS="$CFLAGS" LOPTS="$LDFLAGS"
 }
 
 do_install() {
-       export COPTS="$CFLAGS"
-       export LOPTS="$LDFLAGS"
-       unset CFLAGS
-       unset LDFLAGS
-       oe_runmake 'BASEDIR=${D}' install
+       # We don't need COPTS or LOPTS, but let's be consistent.
+       oe_runmake COPTS="$CFLAGS" LOPTS="$LDFLAGS" 'BASEDIR=${D}' install
 
        if [ "${base_bindir}" != "/bin" ]; then
                mkdir -p ${D}/${base_bindir}