]> code.ossystems Code Review - openembedded-core.git/commitdiff
oeqa/qemurunner: Fix binary vs str issue
authorRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 7 May 2021 17:12:15 +0000 (18:12 +0100)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sun, 9 May 2021 22:23:23 +0000 (23:23 +0100)
The recent logging changes for qemurunner showed up as errors on the
autobuilder where decode couldn't be called on the returned string.
Since the code returns binary data, return b'' instead of '' to match
to avoid tracebacks.

One of these cases was newly added, copied from the other which has
been there for a long time, always broken.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/lib/oeqa/utils/qemurunner.py

index 69fee27511fbd06172e65a57077782cdc333f0df..899152c7adcdfd43faa28e3168bc35e7785c8f21 100644 (file)
@@ -724,7 +724,7 @@ class LoggingThread(threading.Thread):
             data = self.readsock.recv(count)
         except socket.error as e:
             if e.errno == errno.EAGAIN or e.errno == errno.EWOULDBLOCK:
-                return ''
+                return b''
             else:
                 raise
 
@@ -737,7 +737,7 @@ class LoggingThread(threading.Thread):
             # until qemu exits.
             if not self.canexit:
                 raise Exception("Console connection closed unexpectedly")
-            return ''
+            return b''
 
         return data