]> code.ossystems Code Review - openembedded-core.git/commitdiff
oeqa/utils/qemurunner: Fix python ResourceWarning for unclosed file
authorRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 28 Nov 2018 11:18:30 +0000 (11:18 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 6 Dec 2018 10:29:05 +0000 (10:29 +0000)
Fixes:

Stderr:
/media/build1/poky/meta/lib/oeqa/utils/qemurunner.py:381: ResourceWarning: unclosed file <_io.BufferedWriter name=16>
  self.runqemu = None

(From OE-Core rev: b9e0bf919e6fc1a58e02145a363ebe7066e5bf4f)

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/lib/oeqa/utils/qemurunner.py

index c962602a63a46e505d9764d04fb05049fd23462a..983c8c7f1c2fcd83cc87df61a6ae0bbe521c6497 100644 (file)
@@ -369,6 +369,8 @@ class QemuRunner:
             if self.runqemu.poll() is None:
                 self.logger.debug("Sending SIGKILL to runqemu")
                 os.killpg(os.getpgid(self.runqemu.pid), signal.SIGKILL)
+            self.runqemu.stdin.close()
+            self.runqemu.stdout.close()
             self.runqemu = None
         if hasattr(self, 'server_socket') and self.server_socket:
             self.server_socket.close()