]> code.ossystems Code Review - openembedded-core.git/commitdiff
qemu: Avoid potential build configuration contamination
authorRichard Purdie <richard.purdie@linuxfoundation.org>
Sun, 27 Oct 2019 10:11:54 +0000 (10:11 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Mon, 28 Oct 2019 05:30:24 +0000 (05:30 +0000)
Changing the gl options to qemu doesn't result in a correctly rebuilt
binary, the GL linkage can persist from a build where it was enabled
to one where it was not.

As well as clearly being incorrect and non-reproducible, this caused
some mystery failures on the autobuilder.

Cleaning ${B} at do_configure time avoids this. Most recipes
(e.g. autotools derived ones) already clean ${B} as appropriate and
avoid this issue.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-devtools/qemu/qemu.inc

index bb444b63d978a7cbd58969f325c18334feb38ff8..601fc2286b32289b511c2a71d6fc36e60757f32f 100644 (file)
@@ -95,6 +95,7 @@ do_configure_prepend_class-native() {
 do_configure() {
     ${S}/configure ${EXTRA_OECONF}
 }
+do_configure[cleandirs] += "${B}"
 
 do_install () {
        export STRIP=""