]> code.ossystems Code Review - openembedded-core.git/commitdiff
e2fsprogs: Fix a ptest permissions determinism issue
authorRichard Purdie <richard.purdie@linuxfoundation.org>
Sat, 21 Nov 2020 14:47:54 +0000 (14:47 +0000)
committerAnuj Mittal <anuj.mittal@intel.com>
Wed, 25 Nov 2020 15:05:15 +0000 (23:05 +0800)
When comparing builds built with different host umasks, this file jumped out.
The umask from do_compile was influencing ${D} and as cp was used to add the
file it wasn't deterministic. Fix the file mode to ensure determinism.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit 37f37f4a52de3711973b372160f23672b61ff6ad)
Signed-off-by: Anuj Mittal <anuj.mittal@intel.com>
meta/recipes-devtools/e2fsprogs/e2fsprogs_1.45.6.bb

index 15054768dda320924fd0b13148a4da91ce9c9573..e6a4bd1f8c40c4e1b627161450898de97c761a1a 100644 (file)
@@ -125,6 +125,8 @@ do_compile_ptest() {
 }
 
 do_install_ptest() {
+       # This file's permissions depends on the host umask so be deterministic
+       chmod 0644 ${B}/tests/test_data.tmp
        cp -R --no-dereference --preserve=mode,links -v ${B}/tests ${D}${PTEST_PATH}/test
        cp -R --no-dereference --preserve=mode,links -v ${S}/tests/* ${D}${PTEST_PATH}/test
        sed -e 's!../e2fsck/e2fsck!e2fsck!g' \