]> code.ossystems Code Review - openembedded-core.git/commitdiff
sanity.bbclass: If the sanity tests fail, don't mark them as complete
authorRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 17 Apr 2012 11:16:18 +0000 (11:16 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 17 Apr 2012 11:24:59 +0000 (12:24 +0100)
If the sanity tests fail, we still were writing out the stamp which means
they'd get skipped the next time we run bitbake. This is clearly wrong
and we should only write out the stamp file if the sanity tests complete
successfully.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/sanity.bbclass

index 1b941ac58cbc7f7db61be51240781af96760b5f8..4d4abd3ea57803f00a318e4c92a14b771a6ad5e4 100644 (file)
@@ -378,7 +378,7 @@ def check_sanity(e):
         if last_sstate_dir != sstate_dir:
             messages = messages + check_sanity_sstate_dir_change(sstate_dir, e.data)
 
-    if os.path.exists("conf"):
+    if os.path.exists("conf") and not messages:
         f = file(sanityverfile, 'w')
         f.write("SANITY_VERSION %s\n" % sanity_version) 
         f.write("TMPDIR %s\n" % tmpdir)