]> code.ossystems Code Review - openembedded-core.git/commitdiff
initscripts: populate-volatile: don't run commands in background
authorMans Rullgard <mans@mansr.com>
Fri, 16 Dec 2016 16:28:38 +0000 (16:28 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 22 Dec 2016 08:46:36 +0000 (08:46 +0000)
If commands are run asynchronously they may be completed out of
order causing problems if later entries depend on earlier ones.

Signed-off-by: Mans Rullgard <mans@mansr.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
meta/recipes-core/initscripts/initscripts-1.0/populate-volatile.sh

index 91514bac86fa3d1606348be85efc8bc0ef11941a..cf0d2bf9661097221e1297cce9e292bd9d7c4d0e 100755 (executable)
@@ -36,7 +36,7 @@ create_file() {
                [ "${VERBOSE}" != "no" ] && echo "Target already exists. Skipping."
        } || {
                if [ -z "$ROOT_DIR" ]; then
-                       eval $EXEC &
+                       eval $EXEC
                else
                        # Creating some files at rootfs time may fail and should fail,
                        # but these failures should not be logged to make sure the do_rootfs
@@ -86,7 +86,7 @@ link_file() {
        test "$VOLATILE_ENABLE_CACHE" = yes && echo "   $EXEC" >> /etc/volatile.cache.build
 
        if [ -z "$ROOT_DIR" ]; then
-               eval $EXEC &
+               eval $EXEC
        else
                # For the same reason with create_file(), failures should
                # not be logged.
@@ -187,7 +187,7 @@ apply_cfgfile() {
 
                case "${TTYPE}" in
                        "f")  [ "${VERBOSE}" != "no" ] && echo "Creating file -${TNAME}-."
-                               create_file "${TNAME}" &
+                               create_file "${TNAME}"
                                ;;
                        "d")  [ "${VERBOSE}" != "no" ] && echo "Creating directory -${TNAME}-."
                                mk_dir "${TNAME}"