]> code.ossystems Code Review - openembedded-core.git/commitdiff
runqemu-extract-sdk: add --numeric-owner option to tar command
authorChen Qi <qi.chen@windriver.com>
Mon, 21 Oct 2013 02:42:29 +0000 (10:42 +0800)
committerRobert Yang <liezhi.yang@windriver.com>
Wed, 11 Dec 2013 02:12:20 +0000 (21:12 -0500)
If the same username exists on both target and the build host, but
the uids differ, and we start target via NFS, then the uid for the
user will be incorrect on target.

For example, if postfix's uid on host is 119 and on target is 1024,
then if we start target via NFS, the uid for postfix will be 119.

The root cause is that when we use runqemu-extract-sdk to generate
the NFS rootfs for later use, the tar command will respect the username
instead of uid. So if PSEUDO_PASSWD environment is not set correctly,
the host /etc/passwd will be used, resulting in wrong uids.

The situation for gid is completely analogous to that of uid.

It's almost impossible for the runqemu-extract-sdk to guess the correct
location of the needed password file merely based on the target tarball
name.

This patch solves this problem by adding the '--numeric-owner' option
to the tar command so that the uid/gid will be used when extracting the
tarball using runqemu-extract-sdk. In this situation, we'll always get
the correct uid/gid after extracting the tarball.

[YOCTO #5364]

(From OE-Core master rev: acce6ff1a77cfd29e3868faa89b120becb58bbbf)

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
scripts/runqemu-extract-sdk

index 509af6621629dee1e1c17c555922ebaf9c1c1eea..4ce906aef018939d7742543fc1c61b14a69516c4 100755 (executable)
@@ -54,13 +54,13 @@ fi
 
 TAR_OPTS=""
 if [[ "$ROOTFS_TARBALL" =~ tar\.bz2$ ]]; then
-       TAR_OPTS="-xjf"
+       TAR_OPTS="--numeric-owner -xjf"
 fi
 if [[ "$ROOTFS_TARBALL" =~ tar\.gz$ ]]; then
-       TAR_OPTS="-xzf"
+       TAR_OPTS="--numeric-owner -xzf"
 fi
 if [[ "$ROOTFS_TARBALL" =~ \.tar$ ]]; then
-       TAR_OPTS="-xf"
+       TAR_OPTS="--numeric-owner -xf"
 fi
 if [ -z "$TAR_OPTS" ]; then
        echo "Error: Unable to determine sdk tarball format"