]> code.ossystems Code Review - openembedded-core.git/commitdiff
gtk+3: fix reproducible build failure
authorRoss Burton <ross.burton@arm.com>
Mon, 6 Jul 2020 11:57:07 +0000 (12:57 +0100)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 8 Jul 2020 09:37:08 +0000 (10:37 +0100)
There's a build race between the use of a pre-generated file and
re-generating it again, which breaks reproducible builds.  Solve the
race by deleting the shipped generated file.

Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-gnome/gtk+/gtk+3.inc

index e1ecf504a00f8c40a17e4200b4bae9cb76d669c4..8d5edb7ee80177ed66c187c521a5a3a7dfb86ae3 100644 (file)
@@ -1,3 +1,4 @@
+
 SUMMARY = "Multi-platform toolkit for creating GUIs"
 DESCRIPTION = "GTK+ is a multi-platform toolkit for creating graphical user interfaces. Offering a complete \
 set of widgets, GTK+ is suitable for projects ranging from small one-off projects to complete application suites."
@@ -31,6 +32,13 @@ do_configure_prepend() {
     ln -s ${TARGET_PREFIX}libtool libtool
     #delete a file that will get confused with generated one in ${B}
     rm -f ${S}/gtk/gtktypefuncs.c
+
+    # These files are generated by wayland-scanner but will race over modification
+    # time between the copies in the sysroot from wayland-protocols and the copy
+    # in the source tree. Solve the race by deleting so they need to be regenerated.
+    # 3.24.22 will not be shipping these files so this can be deleted then:
+    # https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/2183
+    rm -f ${S}/modules/input/text-input-unstable-v3*.[ch]
 }
 
 EXTRA_OECONF += " \