]> code.ossystems Code Review - openembedded-core.git/commitdiff
lib/oe/patch.py: Clean up getstatusoutput usage
authorRobert Yang <liezhi.yang@windriver.com>
Thu, 23 Aug 2018 08:07:25 +0000 (16:07 +0800)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 23 Aug 2018 17:02:19 +0000 (18:02 +0100)
We can't use subprocess.check_output() or subprocess.call() here since the one
who invokes runcmd() needs handle CmdError() exception (error out or ignore
it).

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/lib/oe/patch.py

index af7aa5235158daa82f1e52cad2abcd28003cc284..e0f0604251a951d60a7887e0d084ae410609f2cf 100644 (file)
@@ -21,6 +21,7 @@ class CmdError(bb.BBHandledException):
 
 def runcmd(args, dir = None):
     import pipes
+    import subprocess
 
     if dir:
         olddir = os.path.abspath(os.curdir)
@@ -33,7 +34,7 @@ def runcmd(args, dir = None):
         args = [ pipes.quote(str(arg)) for arg in args ]
         cmd = " ".join(args)
         # print("cmd: %s" % cmd)
-        (exitstatus, output) = oe.utils.getstatusoutput(cmd)
+        (exitstatus, output) = subprocess.getstatusoutput(cmd)
         if exitstatus != 0:
             raise CmdError(cmd, exitstatus >> 8, output)
         if " fuzz " in output: