]> code.ossystems Code Review - openembedded-core.git/commitdiff
meta/lib/oe/utils.py: Corrected the return value of both_contain()
authorJun Zhu <R01007@freescale.com>
Fri, 3 Apr 2015 14:34:09 +0000 (22:34 +0800)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Mon, 6 Apr 2015 19:36:05 +0000 (20:36 +0100)
oe.utils.both_contain() should return the result as "checkvalue" or "",
but the latest implement returns as "set(['checkvalue'])" or "";

It causes that bitbake.conf generates the wrong result of COMBINED_FEATURES,
which contains the common components in both DISTRO_FEATURE and MACHINE_FEATURES.

For example, build in Dizzy branch, COMBINED_FEATURES is "alsa usbhost ...",
but recently, COMBINED_FEATURES is like "set(['alsa']) set(['usbhost']) ...".

Signed-off-by: Jun Zhu <R01007@freescale.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/lib/oe/utils.py

index bedade292b86748224b6406d2d8d3747631a4dbe..b8224de20b962e38b327b7813df5bd2798496406 100644 (file)
@@ -51,7 +51,7 @@ def both_contain(variable1, variable2, checkvalue, d):
     else:
         checkvalue = set(checkvalue)
     if checkvalue.issubset(val1) and checkvalue.issubset(val2):
-        return checkvalue
+        return " ".join(checkvalue)
     else:
         return ""