]> code.ossystems Code Review - bsp/u-boot.git/commitdiff
env_nand: use nand_spl_load_image for readenv if SPL
authorTim Harvey <tharvey@gateworks.com>
Thu, 14 May 2015 18:48:04 +0000 (11:48 -0700)
committerOtavio Salvador <otavio@ossystems.com.br>
Wed, 20 May 2015 13:53:09 +0000 (10:53 -0300)
The readenv() implementation of env_nand uses the mtd layer which is
unnecessary overhead in SPL when we already have a nand_spl_load_image()
function that doesn't need it. Using this instead eliminates the need
to provide a mtd_read for SPL env as well as reduces code (4KB savings in IMX6
SPL).

Signed-off-by: Tim Harvey <tharvey@gateworks.com>
Acked-by: Scott Wood <scottwood@freescale.com>
common/env_nand.c

index 9c9bb82c0faf81f3d6d6295f99ecfcfd3a1cea2b..92e0e053dfe6b57abe49156bc246e780089a4af0 100644 (file)
@@ -233,6 +233,12 @@ int saveenv(void)
 }
 #endif /* CMD_SAVEENV */
 
+#if defined(CONFIG_SPL_BUILD)
+static int readenv(size_t offset, u_char *buf)
+{
+       return nand_spl_load_image(offset, CONFIG_ENV_SIZE, buf);
+}
+#else
 static int readenv(size_t offset, u_char *buf)
 {
        size_t end = offset + CONFIG_ENV_RANGE;
@@ -266,6 +272,7 @@ static int readenv(size_t offset, u_char *buf)
 
        return 0;
 }
+#endif /* #if defined(CONFIG_SPL_BUILD) */
 
 #ifdef CONFIG_ENV_OFFSET_OOB
 int get_nand_env_oob(nand_info_t *nand, unsigned long *result)