]> code.ossystems Code Review - openembedded-core.git/commitdiff
bitbake/cooker: fix idle command processing in servers
authorJoshua Lock <josh@linux.intel.com>
Wed, 1 Dec 2010 16:59:04 +0000 (16:59 +0000)
committerRichard Purdie <rpurdie@linux.intel.com>
Thu, 9 Dec 2010 12:41:44 +0000 (12:41 +0000)
idle command processing in each of the servers does not handle an explicit
None return value, which means the goggle UI ends up repeatedly adding
"Tasks Summary:" rows to the list.

This patch modifies BBCooker.buildTargets.buildTargetsIdle to return False
when BuildCompleted is fired, as is done in BBCooker.buildFile.buildFileIdle.
It may be that the correct way to fix this is to change the idle command
processing in the servers.

Signed-off-by: Joshua Lock <josh@linux.intel.com>
bitbake/lib/bb/cooker.py

index 054dac863423e0897e3669b16e0bee5f5fe9fe82..8c55e3e643f23b5aa3a55792aad368023ca6f327 100644 (file)
@@ -734,7 +734,7 @@ class BBCooker:
             if not retval:
                 bb.event.fire(bb.event.BuildCompleted(buildname, targets, failures), self.configuration.event_data)
                 self.command.finishAsyncCommand()
-                return None
+                return False
             if retval is True:
                 return True
             return 0.5