]> code.ossystems Code Review - openembedded-core.git/commitdiff
autotools: Correct dependency search logic error
authorRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 12 Feb 2016 11:34:07 +0000 (11:34 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sat, 13 Feb 2016 08:27:17 +0000 (08:27 +0000)
We go to the effort of finding the value of start, we should then use it
rather than relying on the value of dep being preserved from the previous
loop. Took me far too long to notice this issue when changing the code.

Also drop an unused variable.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/autotools.bbclass

index abbc782549c038a7901c56f6a53cf1175c571df7..a5f2bff1ab12b31a3b8ea19456bd385d2279e7a9 100644 (file)
@@ -160,8 +160,8 @@ python autotools_copy_aclocals () {
     # We need to find configure tasks which are either from <target> -> <target>
     # or <native> -> <native> but not <target> -> <native> unless they're direct
     # dependencies. This mirrors what would get restored from sstate.
-    done = [dep]
-    next = [dep]
+    done = [start]
+    next = [start]
     while next:
         new = []
         for dep in next:
@@ -188,7 +188,6 @@ python autotools_copy_aclocals () {
     #bb.warn(str(configuredeps2))
 
     cp = []
-    siteconf = []    
     for c in configuredeps:
         if c.endswith("-native"):
             manifest = d.expand("${SSTATE_MANIFESTS}/manifest-${BUILD_ARCH}-%s.populate_sysroot" % c)