]> code.ossystems Code Review - openembedded-core.git/commitdiff
runqemu: do not check return code of tput
authorChen Qi <Qi.Chen@windriver.com>
Fri, 12 Apr 2019 01:40:06 +0000 (09:40 +0800)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 12 Apr 2019 12:37:11 +0000 (13:37 +0100)
The subprocess.run was replaced by subprocess.check_call because
of compatibility support down to python 3.4. But we really don't
care about whether that command succeeds. Some user reports that
in some tmux environment, this command fails and gives some
unpleasant traceback output. So we use 'call' instead of 'check_call'
to avoid such problem.

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
scripts/runqemu

index c0e569c44cb46923fa43dba113d3cd0de8b975c5..a4fc606e50ca3a2684552c5c415984e4fd287157 100755 (executable)
@@ -1329,7 +1329,8 @@ def main():
             logger.info("SIGTERM received")
             os.kill(config.qemupid, signal.SIGTERM)
             config.cleanup()
-            subprocess.check_call(["tput", "smam"])
+            # Deliberately ignore the return code of 'tput smam'.
+            subprocess.call(["tput", "smam"])
         signal.signal(signal.SIGTERM, sigterm_handler)
 
         config.check_args()
@@ -1351,7 +1352,8 @@ def main():
         return 1
     finally:
         config.cleanup()
-        subprocess.check_call(["tput", "smam"])
+        # Deliberately ignore the return code of 'tput smam'.
+        subprocess.call(["tput", "smam"])
 
 if __name__ == "__main__":
     sys.exit(main())