]> code.ossystems Code Review - openembedded-core.git/commitdiff
openssl: fix ptests
authorPaul Eggleton <paul.eggleton@linux.intel.com>
Mon, 9 Jun 2014 15:37:19 +0000 (16:37 +0100)
committerPaul Eggleton <paul.eggleton@linux.intel.com>
Mon, 9 Jun 2014 15:43:32 +0000 (16:43 +0100)
Add some missing dependencies and fix the Makefile in order to get most
of the ptest tests working (specifically test_bn, test_verify, test_cms,
test_srp and test_heartbeat). test_verify still fails for unknown
reasons (perhaps some of the now expired certificates weren't meant to
have expired as far as the test is concerned?) but at least it has the
certificates to run now.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
meta/recipes-connectivity/openssl/openssl.inc
meta/recipes-connectivity/openssl/openssl/ptest-deps.patch [new file with mode: 0644]
meta/recipes-connectivity/openssl/openssl_1.0.1h.bb

index 6c86588c835fb8e4a227e6773369e3ec7f4da93c..b839c00dde55419e2e568e609a7b6a95488f4d07 100644 (file)
@@ -47,7 +47,7 @@ FILES_${PN}-dev += "${base_libdir}/libcrypto${SOLIBSDEV}"
 FILES_openssl-conf = "${libdir}/ssl/openssl.cnf"
 CONFFILES_openssl-conf = "${libdir}/ssl/openssl.cnf"
 RRECOMMENDS_libcrypto += "openssl-conf"
-RDEPENDS_${PN}-ptest += "${PN}-misc make"
+RDEPENDS_${PN}-ptest += "${PN}-misc make perl perl-module-filehandle bc"
 
 do_configure_prepend_darwin () {
        sed -i -e '/version-script=openssl\.ld/d' Configure
@@ -176,6 +176,7 @@ do_install () {
 
 do_install_ptest () {
        cp -r Makefile test ${D}${PTEST_PATH}
+       cp -r certs ${D}${PTEST_PATH}
        mkdir -p ${D}${PTEST_PATH}/apps
        ln -sf /usr/lib/ssl/misc/CA.sh  ${D}${PTEST_PATH}/apps
        ln -sf /usr/lib/ssl/openssl.cnf ${D}${PTEST_PATH}/apps
diff --git a/meta/recipes-connectivity/openssl/openssl/ptest-deps.patch b/meta/recipes-connectivity/openssl/openssl/ptest-deps.patch
new file mode 100644 (file)
index 0000000..527e10c
--- /dev/null
@@ -0,0 +1,30 @@
+Remove Makefile dependencies for test targets
+
+These are probably here because the executables aren't always built for
+other platforms (e.g. Windows); however we can safely assume they'll
+always be there. None of the other test targets have such dependencies
+and if we don't remove them, make tries to rebuild the executables and
+fails during run-ptest.
+
+Upstream-Status: Inappropriate [config]
+
+Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
+
+diff --git a/test/Makefile b/test/Makefile
+index e6fcfb4..5ae043b 100644
+--- a/test/Makefile
++++ b/test/Makefile
+@@ -322,11 +322,11 @@ test_cms:
+       @echo "CMS consistency test"
+       $(PERL) cms-test.pl
+-test_srp: $(SRPTEST)$(EXE_EXT)
++test_srp:
+       @echo "Test SRP"
+       ../util/shlib_wrap.sh ./srptest
+-test_heartbeat: $(HEARTBEATTEST)$(EXE_EXT)
++test_heartbeat:
+       ../util/shlib_wrap.sh ./$(HEARTBEATTEST)
+ lint:
index ebb1029ef47ed145761ae5d9a08df40ce432c5ce..ddaaba8836667171d8d6b422c8c6d00c7e079bc8 100644 (file)
@@ -35,6 +35,7 @@ SRC_URI += "file://configure-targets.patch \
             file://openssl-fix-des.pod-error.patch \
             file://Makefiles-ptest.patch \
             file://heartbeat-test-private-api.patch \
+            file://ptest-deps.patch \
             file://run-ptest \
            "