]> code.ossystems Code Review - openembedded-core.git/commitdiff
image_types: improve wks path specification
authorChristopher Larson <chris_larson@mentor.com>
Tue, 10 Nov 2015 21:18:20 +0000 (14:18 -0700)
committerJoshua Lock <joshua.g.lock@intel.com>
Thu, 3 Mar 2016 11:02:19 +0000 (11:02 +0000)
Hardcoding a full input path with zero flexibility goes against everything the
Yocto Project is about. Rework it to let the user specify the wks base
filename with WKS_FILE and it'll search the layers for the wks file and use
it.

Signed-off-by: Christopher Larson <chris_larson@mentor.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
(From OE-Core master rev: 8cc7f5229f5447c2183ac319dd52c7ed737ec89b)
Signed-off-by: Joshua Lock <joshua.g.lock@intel.com>
meta/classes/image_types.bbclass

index 50369197c5fb2036f7bc1a3ae86d81b4fc7e7b51..afe8d0cd8f78374dd6a7faede462b7d51c8f659b 100644 (file)
@@ -170,15 +170,37 @@ IMAGE_CMD_ubi () {
 
 IMAGE_CMD_ubifs = "mkfs.ubifs -r ${IMAGE_ROOTFS} -o ${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ubifs ${MKUBIFS_ARGS}"
 
+WKS_FILE ?= "${IMAGE_BASENAME}.${MACHINE}.wks"
+WKS_FILES ?= "${WKS_FILE} ${IMAGE_BASENAME}.wks"
+WKS_SEARCH_PATH ?= "${THISDIR}:${@':'.join('%s/scripts/lib/wic/canned-wks' % l for l in '${BBPATH}:${COREBASE}'.split(':'))}"
+WKS_FULL_PATH = "${@wks_search('${WKS_FILES}'.split(), '${WKS_SEARCH_PATH}') or ''}"
+
+def wks_search(files, search_path):
+    for f in files:
+        if os.path.isabs(f):
+            if os.path.exists(f):
+                return f
+        else:
+            searched = bb.utils.which(search_path, f)
+            if searched:
+                return searched
+
 IMAGE_CMD_wic () {
-       out=${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}
-       wks=${FILE_DIRNAME}/${IMAGE_BASENAME}.${MACHINE}.wks
-       [ -e $wks ] || wks=${FILE_DIRNAME}/${IMAGE_BASENAME}.wks
-       [ -e $wks ] || bbfatal "Kiskstart file $wks doesn't exist"
-       BUILDDIR=${TOPDIR} wic create $wks --vars ${STAGING_DIR_TARGET}/imgdata/ -e ${IMAGE_BASENAME} -o $out/
-       mv $out/build/${IMAGE_BASENAME}*.direct $out.rootfs.wic
-       rm -rf $out/
+       out="${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}"
+       wks="${WKS_FULL_PATH}"
+       if [ -z "$wks" ]; then
+               bbfatal "No kickstart files from WKS_FILES were found: ${WKS_FILES}. Please set WKS_FILE or WKS_FILES appropriately."
+       fi
+
+       BUILDDIR="${TOPDIR}" wic create "$wks" --vars "${STAGING_DIR_TARGET}/imgdata/" -e "${IMAGE_BASENAME}" -o "$out/"
+       mv "$out/build/$(basename "${wks%.wks}")"*.direct "$out.rootfs.wic"
+       rm -rf "$out/"
 }
+IMAGE_CMD_wic[vardepsexclude] = "WKS_FULL_PATH WKS_FILES"
+
+# Rebuild when the wks file changes
+USING_WIC = "${@bb.utils.contains_any('IMAGE_FSTYPES', 'wic ' + ' '.join('wic.%s' % c for c in '${COMPRESSIONTYPES}'.split()), '1', '', d)}"
+do_rootfs[file-checksums] += "${@'${WKS_FULL_PATH}:%s' % os.path.exists('${WKS_FULL_PATH}') if '${USING_WIC}' else ''}"
 
 EXTRA_IMAGECMD = ""