]> code.ossystems Code Review - openembedded-core.git/commitdiff
gcc: Fix intermittent failures during configure
authorMark Hatle <mark.hatle@windriver.com>
Fri, 7 Nov 2014 19:21:57 +0000 (13:21 -0600)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 31 Dec 2014 10:17:15 +0000 (10:17 +0000)
If configure or any of the components it uses from the shared work directory
change, do_configure may fail.

An existing do_preconfigure was created to handle these conditions, but
a 'sed' operation was missed, and a call to gnu-configize was also missed.

(From OE-Core rev: 21c2cfff14442cf224e3568bdbb9bcd4070be247)

Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
meta/recipes-devtools/gcc/gcc-common.inc
meta/recipes-devtools/gcc/gcc-cross-canadian.inc
meta/recipes-devtools/gcc/gcc-cross.inc

index 0bf26b5c6220b8e2488a9dc40f400d9566f5c630..9d41f651edfc1b874a04b2c3fa9c6e83dc019273 100644 (file)
@@ -86,6 +86,8 @@ python do_preconfigure () {
     subprocess.check_output(cmd, stderr=subprocess.STDOUT, shell=True)
     # See 0044-gengtypes.patch, we need to regenerate this file
     bb.utils.remove(d.expand("${S}/gcc/gengtype-lex.c"))
+    cmd = d.expand("sed -i 's/BUILD_INFO=info/BUILD_INFO=/' ${S}/gcc/configure")
+    subprocess.check_output(cmd, stderr=subprocess.STDOUT, shell=True)
 }
 addtask do_preconfigure after do_patch before do_configure
 do_preconfigure[depends] += "gnu-config-native:do_populate_sysroot autoconf-native:do_populate_sysroot"
index 0b1f37b908a6e49d54320c177a7b74e8e065440c..ba001a9118a5e519f5a41a56b8b92dbbe3953948 100644 (file)
@@ -55,7 +55,6 @@ do_configure () {
        export CPPFLAGS_FOR_TARGET="${TARGET_CPPFLAGS}"
        export CXXFLAGS_FOR_TARGET="${TARGET_CXXFLAGS}"
        export LDFLAGS_FOR_TARGET="${TARGET_LDFLAGS}"
-       (cd ${S} && gnu-configize) || die "failure running gnu-configize"
        oe_runconf
 }
 
index 4cdb55f3eef47a3dfa12672cd1c7600049d88ebc..4cae160e782e85bcaa4f2a7868938568180dc0ad 100644 (file)
@@ -32,10 +32,6 @@ EXTRA_OECONF_PATHS = "\
 
 ARCH_FLAGS_FOR_TARGET += "-isystem${STAGING_DIR_TARGET}${target_includedir}"
 
-do_configure_prepend () {
-       sed -i 's/BUILD_INFO=info/BUILD_INFO=/' ${S}/gcc/configure
-}
-
 do_compile () {
        export CC="${BUILD_CC}"
        export AR_FOR_TARGET="${TARGET_SYS}-ar"