]> code.ossystems Code Review - openembedded-core.git/commitdiff
libusb1: fix make install race
authorRoss Burton <ross.burton@intel.com>
Fri, 13 Nov 2015 14:41:53 +0000 (14:41 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 25 Nov 2015 07:48:19 +0000 (07:48 +0000)
There's an install race in when building in parallel, remove a redundant rule to
stop it happening.

Signed-off-by: Ross Burton <ross.burton@intel.com>
meta/recipes-support/libusb/libusb1/no-dll.patch [new file with mode: 0644]
meta/recipes-support/libusb/libusb1_1.0.20.bb

diff --git a/meta/recipes-support/libusb/libusb1/no-dll.patch b/meta/recipes-support/libusb/libusb1/no-dll.patch
new file mode 100644 (file)
index 0000000..6e6bb83
--- /dev/null
@@ -0,0 +1,19 @@
+As all invokes all-recursive which uses sub-makes to invoke all-am, the
+resulting makefile wants to build libusb-1.0.la twice. In non-parallel builds
+the second attempt is skipped as the target already exists, but in highly
+parallel builds it's likely that two makes will be building libusb-1.0.la at the
+same time.
+
+Solve this by removing the explicit all target, which as libusb-1.0.dll isn't
+built under Linux is redundant anyway.
+
+Upstream-Status: Pending
+Signed-off-by: Ross Burton <ross.burton@intel.com>
+
+diff --git a/libusb/Makefile.am b/libusb/Makefile.am
+index 0cab0a0..c880213 100644
+--- a/libusb/Makefile.am
++++ b/libusb/Makefile.am
+@@ -1,2 +0,0 @@
+-all: libusb-1.0.la libusb-1.0.dll
+-
index 21b8b45a6a11ba9780f6da0485094aed6a4cd0cc..4cad2d4be7526252a1a903af24fda6dad05a7cc7 100644 (file)
@@ -9,6 +9,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=fbc093901857fcd118f065f900982c24"
 BBCLASSEXTEND = "native nativesdk"
 
 SRC_URI = "${SOURCEFORGE_MIRROR}/libusb/libusb-${PV}.tar.bz2 \
+           file://no-dll.patch \
           "
 
 SRC_URI[md5sum] = "1d4eb194eaaa2bcfbba28102768c7dbf"