]> code.ossystems Code Review - openembedded-core.git/commitdiff
lib/oe/gpg_sign: fix output in error paths
authorRoss Burton <ross.burton@intel.com>
Thu, 21 Jul 2016 14:59:40 +0000 (15:59 +0100)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Mon, 25 Jul 2016 22:47:00 +0000 (23:47 +0100)
oe.utils.getstatusoutput() is a wrapper for subprocess.getstatusoutput() which
uses Universal Newlines, so the output is a str() not bytes().

Signed-off-by: Ross Burton <ross.burton@intel.com>
meta/lib/oe/gpg_sign.py

index a8a478aa95974ed4134b1bedba547f101a453c53..38eb0cb137cde8b0653e82d1ec043307e43c4be0 100644 (file)
@@ -24,7 +24,7 @@ class LocalSigner(object):
         status, output = oe.utils.getstatusoutput(cmd)
         if status:
             raise bb.build.FuncFailed('Failed to export gpg public key (%s): %s' %
-                                      (keyid, output.decode("utf-8")))
+                                      (keyid, output))
 
     def sign_rpms(self, files, keyid, passphrase):
         """Sign RPM files"""
@@ -39,7 +39,7 @@ class LocalSigner(object):
 
         status, output = oe.utils.getstatusoutput(cmd)
         if status:
-            raise bb.build.FuncFailed("Failed to sign RPM packages: %s" % output.decode("utf-8"))
+            raise bb.build.FuncFailed("Failed to sign RPM packages: %s" % output)
 
     def detach_sign(self, input_file, keyid, passphrase_file, passphrase=None, armor=True):
         """Create a detached signature of a file"""
@@ -113,4 +113,3 @@ def get_signer(d, backend):
         return LocalSigner(d)
     else:
         bb.fatal("Unsupported signing backend '%s'" % backend)
-