]> code.ossystems Code Review - openembedded-core.git/commitdiff
image.py: Avoid creating empty .env file in _write_wic_env
authorMike Crowe <mac@mcrowe.com>
Thu, 19 Nov 2015 11:21:16 +0000 (11:21 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 1 Dec 2015 21:30:53 +0000 (21:30 +0000)
Creating a file for every image containing a few variables isn't
necessary if wic is not being used, so don't write the file if WICVARS
is empty.

Signed-off-by: Mike Crowe <mac@mcrowe.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
meta/lib/oe/image.py

index 9580562580330a72a37d04e2f6ff4c2b3a2afed3..f0843de928c46889ddb37c70d9453a9ab2dc8d38 100644 (file)
@@ -335,13 +335,17 @@ class Image(ImageDepGraph):
         Write environment variables used by wic
         to tmp/sysroots/<machine>/imgdata/<image>.env
         """
+        wicvars = self.d.getVar('WICVARS', True)
+        if not wicvars:
+            return
+
         stdir = self.d.getVar('STAGING_DIR_TARGET', True)
         outdir = os.path.join(stdir, 'imgdata')
         if not os.path.exists(outdir):
             os.makedirs(outdir)
         basename = self.d.getVar('IMAGE_BASENAME', True)
         with open(os.path.join(outdir, basename) + '.env', 'w') as envf:
-            for var in self.d.getVar('WICVARS', True).split():
+            for var in wicvars.split():
                 value = self.d.getVar(var, True)
                 if value:
                     envf.write('%s="%s"\n' % (var, value.strip()))