]> code.ossystems Code Review - openembedded-core.git/commitdiff
udev-hwdb: fix postinstall scripts failures when multilib enabled
authorKai Kang <kai.kang@windriver.com>
Thu, 18 Oct 2018 08:18:05 +0000 (04:18 -0400)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Mon, 22 Oct 2018 06:05:13 +0000 (07:05 +0100)
When multilib is enabled and both udev-hwdb and ${MLPREFIX}udev-hwdb are
installed to image, it fails to run one of their postinstall scripts
that they both call ${base_bindir}/udevadm with same user mode qemu.

Duplicate udevadm and add postinst-intercept update_udev_hwdb to fix the
failures.

Signed-off-by: Kai Kang <kai.kang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-core/systemd/systemd_239.bb
meta/recipes-core/udev/eudev_3.2.5.bb
scripts/postinst-intercepts/update_udev_hwdb [new file with mode: 0644]

index bc16407e09559cd8059112e38ebb7f4cc25aa9f8..acdce5cee72c6f11e218280440eab04819f72967 100644 (file)
@@ -282,6 +282,10 @@ do_install() {
        rm -f ${D}${sysconfdir}/systemd/logind.conf
        rm -f ${D}${sysconfdir}/systemd/system.conf
        rm -f ${D}${sysconfdir}/systemd/user.conf
+
+       # duplicate udevadm for postinst script
+       install -d ${D}${libexecdir}
+       ln ${D}${base_bindir}/udevadm ${D}${libexecdir}/${MLPREFIX}udevadm
 }
 
 
@@ -532,6 +536,7 @@ FILES_udev += "${base_sbindir}/udevd \
                ${systemd_unitdir}/system/*udev* \
                ${systemd_unitdir}/system/*.wants/*udev* \
                ${base_bindir}/udevadm \
+               ${libexecdir}/${MLPREFIX}udevadm \
                ${datadir}/bash-completion/completions/udevadm \
               "
 
@@ -570,13 +575,7 @@ pkg_prerm_${PN} () {
 PACKAGE_WRITE_DEPS += "qemu-native"
 pkg_postinst_udev-hwdb () {
        if test -n "$D"; then
-               if ${@bb.utils.contains('MACHINE_FEATURES', 'qemu-usermode', 'true','false', d)}; then
-                       ${@qemu_run_binary(d, '$D', '${base_bindir}/udevadm')} hwdb --update \
-                               --root $D
-                       chown root:root $D${sysconfdir}/udev/hwdb.bin
-               else
-                       $INTERCEPT_DIR/postinst_intercept delay_to_first_boot ${PKG} mlprefix=${MLPREFIX}
-               fi
+               $INTERCEPT_DIR/postinst_intercept update_udev_hwdb ${PKG} mlprefix=${MLPREFIX} binprefix=${MLPREFIX}
        else
                udevadm hwdb --update
        fi
index efd62c6495a2410d626ca17e36dbe9f71a461837..592dd8f22a9b76f29f5f0647a836633c7363c030 100644 (file)
@@ -50,6 +50,10 @@ do_install_append() {
 
        # hid2hci has moved to bluez4. removed in udev as of version 169
        rm -f ${D}${base_libdir}/udev/hid2hci
+
+       # duplicate udevadm for postinst script
+       install -d ${D}${libexecdir}
+       ln ${D}${bindir}/udevadm ${D}${libexecdir}/${MLPREFIX}udevadm
 }
 
 do_install_prepend_class-target () {
@@ -81,12 +85,7 @@ RPROVIDES_eudev-hwdb += "udev-hwdb"
 PACKAGE_WRITE_DEPS += "qemu-native"
 pkg_postinst_eudev-hwdb () {
     if test -n "$D"; then
-        if ${@bb.utils.contains('MACHINE_FEATURES', 'qemu-usermode', 'true','false', d)}; then
-            ${@qemu_run_binary(d, '$D', '${bindir}/udevadm')} hwdb --update --root $D
-            chown root:root $D${sysconfdir}/udev/hwdb.bin
-        else
-            $INTERCEPT_DIR/postinst_intercept delay_to_first_boot ${PKG} mlprefix=${MLPREFIX}
-        fi
+        $INTERCEPT_DIR/postinst_intercept update_udev_hwdb ${PKG} mlprefix=${MLPREFIX} binprefix=${MLPREFIX}
     else
         udevadm hwdb --update
     fi
diff --git a/scripts/postinst-intercepts/update_udev_hwdb b/scripts/postinst-intercepts/update_udev_hwdb
new file mode 100644 (file)
index 0000000..b5cce0a
--- /dev/null
@@ -0,0 +1,6 @@
+#!/bin/sh
+
+set -e
+
+PSEUDO_UNLOAD=1 ${binprefix}qemuwrapper -L $D $D${libexecdir}/${binprefix}udevadm hwdb --update --root $D
+chown root:root $D${sysconfdir}/udev/hwdb.bin