]> code.ossystems Code Review - openembedded-core.git/commitdiff
base-files/profile: change EDITOR to not be busybox specific
authorPaul Gortmaker <paul.gortmaker@windriver.com>
Wed, 21 Jan 2015 18:25:06 +0000 (13:25 -0500)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sat, 14 Feb 2015 08:40:35 +0000 (08:40 +0000)
Setting "EDITOR=/bin/vi" breaks on non-busybox systems, as
vim will populate /usr/bin/vi instead, and you get stuff like:

  op3:~/poky/meta-builder$ git commit -s
  error: cannot run /bin/vi: No such file or directory
  error: unable to start editor '/bin/vi'
  Please supply the message using either -m or -F option.
  op3:~/poky/meta-builder$ which vi
  /usr/bin/vi
  op3:~/poky/meta-builder$

Since we've already specified a proper path above in the profile,
we've no need to call out where in the path vi lives, and hence
this will work with busybox and a full vim install w/o busybox.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
meta/recipes-core/base-files/base-files/profile

index 88ab8d877b0dac7ac174c75eea44031f9d24c1c9..53c2680409dd639151b0324eaaa359a64fceb198 100644 (file)
@@ -2,7 +2,7 @@
 # and Bourne compatible shells (bash(1), ksh(1), ash(1), ...).
 
 PATH="/usr/local/bin:/usr/bin:/bin"
-EDITOR="/bin/vi"                       # needed for packages like cron
+EDITOR="vi"                    # needed for packages like cron, git-commit
 test -z "$TERM" && TERM="vt100"        # Basic terminal capab. For screen etc.
 
 if [ ! -e /etc/localtime -a ! -e /etc/TZ ]; then