]> code.ossystems Code Review - openembedded-core.git/commitdiff
selftest/reproducible: Don't call sync between each file compare
authorRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 26 Feb 2021 17:45:20 +0000 (17:45 +0000)
committerSteve Sakoman <steve@sakoman.com>
Thu, 4 Mar 2021 14:19:50 +0000 (04:19 -1000)
Calling sync between each file compare is horrible performance wise
as we compare thousands of files. We don't care about IO latency here
so disable.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit 25f78abd8bbeb201fd9452e7983e015027954948)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
meta/lib/oeqa/selftest/cases/reproducible.py

index d4800022df6251bbb02d0b683b6428bf6058c6d4..7f74cec28facaf57e60d2dca2d1dc0944b736723 100644 (file)
@@ -68,7 +68,7 @@ def compare_file(reference, test, diffutils_sysroot):
         result.status = MISSING
         return result
 
-    r = runCmd(['cmp', '--quiet', reference, test], native_sysroot=diffutils_sysroot, ignore_status=True)
+    r = runCmd(['cmp', '--quiet', reference, test], native_sysroot=diffutils_sysroot, ignore_status=True, sync=False)
 
     if r.status:
         result.status = DIFFERENT