]> code.ossystems Code Review - openembedded-core.git/commitdiff
rpcbind: refresh patches
authorRoss Burton <ross.burton@intel.com>
Fri, 9 Mar 2018 18:56:01 +0000 (20:56 +0200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sun, 11 Mar 2018 13:25:22 +0000 (06:25 -0700)
The patch tool will apply patches by default with "fuzz", which is where if the
hunk context isn't present but what is there is close enough, it will force the
patch in.

Whilst this is useful when there's just whitespace changes, when applied to
source it is possible for a patch applied with fuzz to produce broken code which
still compiles (see #10450).  This is obviously bad.

We'd like to eventually have do_patch() rejecting any fuzz on these grounds. For
that to be realistic the existing patches with fuzz need to be rebased and
reviewed.

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Alexander Kanavin <alexander.kanavin@linux.intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
meta/recipes-extended/rpcbind/rpcbind/pmapproc_dump-Fixed-typo-in-memory-leak-patch.patch

index 859e67bbe05997c63b5d5043d747635a38c4f227..4c23ee01ca2c1a724c61d086d8048ce95c3109df 100644 (file)
@@ -15,19 +15,16 @@ Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
  src/pmap_svc.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
-diff --git a/src/pmap_svc.c b/src/pmap_svc.c
-index e926cdc..26c31d0 100644
---- a/src/pmap_svc.c
-+++ b/src/pmap_svc.c
-@@ -384,7 +384,7 @@ pmapproc_dump(struct svc_req *rqstp /*__unused*/, SVCXPRT *xprt)
+Index: rpcbind-0.2.4/src/pmap_svc.c
+===================================================================
+--- rpcbind-0.2.4.orig/src/pmap_svc.c
++++ rpcbind-0.2.4/src/pmap_svc.c
+@@ -384,7 +384,7 @@ pmapproc_dump(struct svc_req *rqstp /*__
        }
  
  done:
 -      if (!svc_freeargs(xprt, (xdrproc_t) xdr_pmap, (char *)NULL)) {
 +      if (!svc_freeargs(xprt, (xdrproc_t) xdr_void, (char *)NULL)) {
                if (debugging) {
-                       (void) xlog(LOG_DEBUG, "unable to free arguments\n");
+                       /*(void) xlog(LOG_DEBUG, "unable to free arguments\n");*/
                        if (doabort) {
--- 
-2.7.4
-