]> code.ossystems Code Review - openembedded-core.git/commitdiff
gtk+3: Fix build failure with gold linker
authorKhem Raj <raj.khem@gmail.com>
Thu, 21 Feb 2019 22:18:34 +0000 (14:18 -0800)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Mon, 25 Feb 2019 10:42:56 +0000 (10:42 +0000)
Explicitly link in libfribidi

Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-gnome/gtk+/gtk+3/link_fribidi.patch [new file with mode: 0644]
meta/recipes-gnome/gtk+/gtk+3_3.24.5.bb

diff --git a/meta/recipes-gnome/gtk+/gtk+3/link_fribidi.patch b/meta/recipes-gnome/gtk+/gtk+3/link_fribidi.patch
new file mode 100644 (file)
index 0000000..e4bbd79
--- /dev/null
@@ -0,0 +1,19 @@
+Link with libfribidi, this is to avoid under linking where these functions are
+used but the library is not linked in, and they are marked undefined by BFD linker
+but gold linker refuses to link
+
+| ./.libs/libgdk-3.so: error: undefined reference to 'fribidi_get_bidi_type'
+
+Signed-off-by: Khem Raj <raj.khem@gmail.com>
+Upstream-Status: Pending
+
+--- a/gdk/Makefile.am
++++ b/gdk/Makefile.am
+@@ -55,6 +55,7 @@ LDADD =                                      \
+       -version-info $(LT_VERSION_INFO)        \
+       -export-dynamic                         \
+       -rpath $(libdir)                        \
++      -lfribidi                               \
+       $(no_undefined)
+ #
index 799cbd4707e3b7349d0f46fe2b70863cc980584a..92c9a3ebfb54d9509b17a4813321dc9ea130d61e 100644 (file)
@@ -6,6 +6,7 @@ SRC_URI = "http://ftp.gnome.org/pub/gnome/sources/gtk+/${MAJ_VER}/gtk+-${PV}.tar
            file://0001-Hardcoded-libtool.patch \
            file://0002-Do-not-try-to-initialize-GL-without-libGL.patch \
            file://0003-Add-disable-opengl-configure-option.patch \
+           file://link_fribidi.patch \
           "
 SRC_URI[md5sum] = "32862355c08f6af3e7848c695cd4081b"
 SRC_URI[sha256sum] = "0be5fb0d302bc3de26ab58c32990d895831e2b7c7418d0ffea1206d6a3ddb02f"