]> code.ossystems Code Review - openembedded-core.git/commitdiff
python3: Disable PGO for reproducible builds
authorJoshua Watt <jpewhacker@gmail.com>
Thu, 20 Jun 2019 15:43:02 +0000 (10:43 -0500)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 20 Jun 2019 23:26:09 +0000 (00:26 +0100)
Enabling PGO for python current causes it to not be reproducible when
building, so disable it for now.

Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-devtools/python/python3_3.7.3.bb

index 2444296142113091edab920d6e83a1f3d77ed3c4..8e77dbe9595ea187950d79648e5486f0b650eb15 100644 (file)
@@ -75,8 +75,16 @@ CACHED_CONFIGUREVARS = " \
                 ac_cv_file__dev_ptc=no \
                 ac_cv_working_tzset=yes \
 "
+python() {
+    # PGO currently causes builds to not be reproducible, so disable it for
+    # now. See YOCTO #13407
+    if bb.utils.contains('MACHINE_FEATURES', 'qemu-usermode', True, False, d) and d.getVar('BUILD_REPRODUCIBLE_BINARIES') != '1':
+        d.setVar('PACKAGECONFIG_PGO', 'pgo')
+    else:
+        d.setVar('PACKAGECONFIG_PGO', '')
+}
 
-PACKAGECONFIG_class-target ??= "readline ${@bb.utils.contains('MACHINE_FEATURES', 'qemu-usermode', 'pgo', '', d)}"
+PACKAGECONFIG_class-target ??= "readline ${PACKAGECONFIG_PGO}"
 PACKAGECONFIG_class-native ??= "readline"
 PACKAGECONFIG_class-nativesdk ??= "readline"
 PACKAGECONFIG[readline] = ",,readline"