]> code.ossystems Code Review - openembedded-core.git/commitdiff
arch-arm*: Fix bugs with dsp and simd feature include files
authorJon Mason <jdmason@kudzu.us>
Sat, 21 Aug 2021 19:32:16 +0000 (15:32 -0400)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sun, 22 Aug 2021 21:21:12 +0000 (22:21 +0100)
Fix bugs found with a duplicate inclusion of feature-arm-simd.inc and
dsp not being defined in feature-arm-dsp.inc

Found by compiling with DEFAULTTUNE set to 'armv8r' and 'cortexm33'
respectively.

Signed-off-by: Jon Mason <jdmason@kudzu.us>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/conf/machine/include/arm/arch-armv5-dsp.inc
meta/conf/machine/include/arm/arch-armv8r.inc
meta/conf/machine/include/arm/feature-arm-dsp.inc

index d296e827cf66fc64933a6dcac9de0a6de096b7cb..f3c749d7223e646174181ec21edf974d7cde0e20 100644 (file)
@@ -1,3 +1,4 @@
+# Can't use feature-arm-dsp.inc, since that will add "+dsp", which isn't supported in GCC for ARMv5
 ARMPKGSFX_DSP = "${@bb.utils.contains('TUNE_FEATURES', [ 'dsp' ], 'e', '', d)}"
 TUNEVALID[dsp] = "ARM DSP functionality"
 
index be4ef3e629df0bfd5d6d68605085186441af1cc0..0dcfd34c1a2b0b7268a7ddfb310047951a226702 100644 (file)
@@ -8,7 +8,6 @@ TUNE_CCARGS_MARCH .= "${@bb.utils.contains('TUNE_FEATURES', 'armv8r', ' -march=a
 MACHINEOVERRIDES =. "${@bb.utils.contains('TUNE_FEATURES', 'armv8r', 'armv8r:', '', d)}"
 
 require conf/machine/include/arm/arch-arm64.inc
-require conf/machine/include/arm/feature-arm-simd.inc
 require conf/machine/include/arm/feature-arm-crc.inc
 require conf/machine/include/arm/feature-arm-crypto.inc
 
index ec5007a8ca75d07d2910e1804fc46db44cc6c631..7f7ada7461ca948e5c717cdd1f190c1c645088ca 100644 (file)
@@ -1,2 +1,3 @@
-# Note: TUNEVALID set in conf/machine/include/arm/arch-armv5-dsp.inc
+ARMPKGSFX_DSP = "${@bb.utils.contains('TUNE_FEATURES', [ 'dsp' ], 'e', '', d)}"
+TUNEVALID[dsp] = "ARM DSP functionality"
 TUNE_CCARGS_MARCH_OPTS .= "${@bb.utils.contains('TUNE_FEATURES', [ 'dsp' ], '+dsp', '', d)}"