]> code.ossystems Code Review - openembedded-core.git/commitdiff
rng-tools: Fix crazy defaults
authorRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 3 Nov 2017 16:17:01 +0000 (16:17 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 3 Nov 2017 16:53:32 +0000 (16:53 +0000)
Feeding the output of /dev/urandom into /dev/random is pretty much insane
and not something we should encourage.

I can't really imagine a scenario where this would be a sensible idea since
/dev/urandom if effectively derived from /dev/random.

This changes the tool to default to /dev/hwrng which makes much more sense,
feeding hardware entropy into the random pool. In the QEMU case, this will
feed entropy from the host into the guests which is also what we want.

Yes, this change will cause rngd not to start if /dev/hwrng isn't present,
but it isn't needed if that isn't so I don't see this as a bad thing.

(https://wiki.archlinux.org/index.php/Rng-tools has a section in red which
agrees with the above, "this is a really bad idea, since you are simple
filling the kernel entropy pool with entropy coming from the kernel itself!")

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-support/rng-tools/rng-tools/default

index 7aede9be0305ead390524623eee1a91c41a38f32..ab7cd9327f3e58431c9174273c227d2a2f8b2784 100644 (file)
@@ -1,3 +1,2 @@
 # Specify rng device
-#RNG_DEVICE=/dev/hwrng
-RNG_DEVICE=/dev/urandom
+RNG_DEVICE=/dev/hwrng