]> code.ossystems Code Review - openembedded-core.git/commitdiff
targetcontrol.py: use oe.types.boolean for QEMU_USE_KVM
authorRobert Yang <liezhi.yang@windriver.com>
Mon, 13 Nov 2017 18:19:22 +0000 (02:19 +0800)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Mon, 18 Dec 2017 18:00:22 +0000 (18:00 +0000)
So that both QEMU_USE_KVM = "True" and "1" will work.

[YOCTO #12343]

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
meta/classes/testimage.bbclass
meta/lib/oeqa/targetcontrol.py

index 45bb2bda3b8d6e7e9a5f83cb149dc0e852301896..7260ad4517a42498d40894e5ce13ee3c03f87b4e 100644 (file)
@@ -215,7 +215,7 @@ def testimage_main(d):
     # Get use_kvm
     qemu_use_kvm = d.getVar("QEMU_USE_KVM")
     if qemu_use_kvm and \
-       (qemu_use_kvm == 'True' and 'x86' in machine or \
+       (oe.types.boolean(qemu_use_kvm) and 'x86' in machine or \
         d.getVar('MACHINE') in qemu_use_kvm.split()):
         kvm = True
     else:
index f63936c3ec4e97aa06c8379495fa28ea559cf5ea..59a9c35a096035e92c82d9dcc2a90e99c4f56dbc 100644 (file)
@@ -91,6 +91,8 @@ class QemuTarget(BaseTarget):
 
     def __init__(self, d, logger, image_fstype=None):
 
+        import oe.types
+
         super(QemuTarget, self).__init__(d, logger)
 
         self.rootfs = ''
@@ -107,7 +109,7 @@ class QemuTarget(BaseTarget):
         dump_dir = d.getVar("TESTIMAGE_DUMP_DIR")
         qemu_use_kvm = d.getVar("QEMU_USE_KVM")
         if qemu_use_kvm and \
-           (qemu_use_kvm == "True" and "x86" in d.getVar("MACHINE") or \
+           (oe.types.boolean(qemu_use_kvm) and "x86" in d.getVar("MACHINE") or \
             d.getVar("MACHINE") in qemu_use_kvm.split()):
             use_kvm = True
         else: