]> code.ossystems Code Review - openembedded-core.git/commitdiff
lib/oe/image.py: add error checking for missing IMAGE_CMD
authorPaul Eggleton <paul.eggleton@linux.intel.com>
Tue, 27 Jan 2015 10:02:38 +0000 (10:02 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 3 Feb 2015 14:53:40 +0000 (14:53 +0000)
An invalid value in IMAGE_FSTYPES was triggering a traceback. Add a
check and a reasonable error message instead.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
meta/lib/oe/image.py

index f9c8f84cf8801d01616cee82582cf163a955d6bb..0ce303d570168c60d0a8e56df690d55453efb9fa 100644 (file)
@@ -296,7 +296,11 @@ class Image(ImageDepGraph):
                 bb.data.update_data(localdata)
                 localdata.setVar('type', type)
 
-                cmds.append("\t" + localdata.getVar("IMAGE_CMD", True))
+                image_cmd = localdata.getVar("IMAGE_CMD", True)
+                if image_cmd:
+                    cmds.append("\t" + image_cmd)
+                else:
+                    bb.fatal("No IMAGE_CMD defined for IMAGE_FSTYPES entry '%s' - possibly invalid type name or missing support class" % type)
                 cmds.append(localdata.expand("\tcd ${DEPLOY_DIR_IMAGE}"))
 
                 if type in cimages: