]> code.ossystems Code Review - openembedded-core.git/commitdiff
image-buildinfo,oeqa/selftest/containerimage: Ensure image-buildinfo doesn't break...
authorRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 9 Nov 2018 11:24:47 +0000 (11:24 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 6 Dec 2018 13:58:44 +0000 (13:58 +0000)
Having image-buildinfo enabled causes containerimage.ContainerImageTests.test_expected_files
to fail due to the presence of an unexpected file:
  ['./',
   './etc/',
-  './etc/build',
   './etc/default/',
   './etc/default/postinst',

Tweak the class to allow it to be disabled and disable it from the test just in
case it was enabled.

(From OE-Core rev: af67bf422a4df5b7e07894512ff73a5f493682ab)

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/image-buildinfo.bbclass
meta/lib/oeqa/selftest/cases/containerimage.py

index 213fb9cf9b61f7c4111ff3bde97efcdfc6a5f2c9..87a6a1a48935ddc52b59d07c106dfe6ca676fbf8 100644 (file)
@@ -64,6 +64,8 @@ def buildinfo_target(d):
 
 # Write build information to target filesystem
 python buildinfo () {
+    if not d.getVar('IMAGE_BUILDINFO_FILE'):
+        return
     with open(d.expand('${IMAGE_ROOTFS}${IMAGE_BUILDINFO_FILE}'), 'w') as build:
         build.writelines((
             '''-----------------------
index 99a5cc9e5751279492c8f8e66ac3237d7b9570a8..8deaae75d8ad85c2f341bc5626c8c49ee1687ffd 100644 (file)
@@ -39,6 +39,7 @@ class ContainerImageTests(OESelftestTestCase):
 IMAGE_FSTYPES = "container"
 PACKAGE_CLASSES = "package_ipk"
 IMAGE_FEATURES = ""
+IMAGE_BUILDINFO_FILE = ""
 """)
 
         bbvars = get_bb_vars(['bindir', 'sysconfdir', 'localstatedir',