]> code.ossystems Code Review - openembedded-core.git/commitdiff
oeqa/utils/qemurunner: use the right kill call so we don't send SIGTERM to bitbake...
authorStefan Stanacar <stefanx.stanacar@intel.com>
Tue, 11 Mar 2014 12:11:08 +0000 (14:11 +0200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 11 Mar 2014 14:52:41 +0000 (07:52 -0700)
After recent bitbake-worker changes [1] this was killing the bitbake-worker,
which isn't what we want and kill(-pid) was the wrong call anyway.

runqemu.pid is the right PGID as the process was started with preexec_fn=setpgrp
(so no need to do os.getpgid(self.runqemu.pid))

[1] http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/?id=15688798520896690561824b2fdc227c8a365c82

Signed-off-by: Stefan Stanacar <stefanx.stanacar@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/lib/oeqa/utils/qemurunner.py

index 5366a635fedbc4340442596d0c8e0efe6604d1d8..337b5874b28ba172c7139f476a3a2d9b29697f59 100644 (file)
@@ -163,13 +163,13 @@ class QemuRunner:
 
         if self.runqemu:
             bb.note("Sending SIGTERM to runqemu")
-            os.kill(-self.runqemu.pid,signal.SIGTERM)
+            os.killpg(self.runqemu.pid, signal.SIGTERM)
             endtime = time.time() + self.runqemutime
             while self.runqemu.poll() is None and time.time() < endtime:
                 time.sleep(1)
             if self.runqemu.poll() is None:
                 bb.note("Sending SIGKILL to runqemu")
-                os.kill(-self.runqemu.pid,signal.SIGKILL)
+                os.killpg(self.runqemu.pid, signal.SIGKILL)
             self.runqemu = None
         if self.server_socket:
             self.server_socket.close()