]> code.ossystems Code Review - openembedded-core.git/commitdiff
usbutils 0.91: Fix NULL pointer crash.
authorRoy.Li <rongqing.li@windriver.com>
Fri, 27 Jul 2012 12:03:07 +0000 (20:03 +0800)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sat, 28 Jul 2012 10:17:01 +0000 (11:17 +0100)
[YOCTO #2847]

Before use usbbuslist, we should check if it is valid.

Signed-off-by: Roy.Li <rongqing.li@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-bsp/usbutils/usbutils/Fix-NULL-pointer-crash.patch [new file with mode: 0644]
meta/recipes-bsp/usbutils/usbutils_0.91.bb

diff --git a/meta/recipes-bsp/usbutils/usbutils/Fix-NULL-pointer-crash.patch b/meta/recipes-bsp/usbutils/usbutils/Fix-NULL-pointer-crash.patch
new file mode 100644 (file)
index 0000000..0efdc59
--- /dev/null
@@ -0,0 +1,28 @@
+Fix NULL pointer crash.
+
+Before use usbbuslist, we should check if it is valid.
+
+Upstream-Status: Pending
+Signed-off-by: Roy.Li <rongqing.li@windriver.com>
+---
+ lsusb-t.c |    4 ++++
+ 1 files changed, 4 insertions(+), 0 deletions(-)
+
+diff --git a/lsusb-t.c b/lsusb-t.c
+index f604155..583a46a 100644
+--- a/lsusb-t.c
++++ b/lsusb-t.c
+@@ -643,6 +643,10 @@ static void sort_busses(void)
+       /* need to reverse sort bus numbers */
+       struct usbbusnode *t, *p, **pp;
+       int swapped;
++
++      if (!usbbuslist)
++              return;
++
+       do {
+               p = usbbuslist;
+               pp = &usbbuslist;
+-- 
+1.7.4.1
+
index 04d1681e1d3e7f67e25d6190f4b34874d99cfa24..abe807cd3355bf1cd6dacef0cf7cf6113e128c6d 100644 (file)
@@ -7,10 +7,11 @@ LICENSE = "GPLv2+"
 LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
 
 DEPENDS = "libusb zlib"
-PR = "r4"
+PR = "r5"
 
 SRC_URI = "${KERNELORG_MIRROR}/linux/utils/usb/usbutils/usbutils-${PV}.tar.gz \
-           file://usb-devices-avoid-dependency-on-bash.patch"
+           file://usb-devices-avoid-dependency-on-bash.patch \
+           file://Fix-NULL-pointer-crash.patch"
 
 SRC_URI[md5sum] = "49de2403b40bf3a9863faaa8d3858deb"
 SRC_URI[sha256sum] = "c122346b0225121bcf159abf804116f826a4a3462c94ce7b8871f7559e6b3a46"