]> code.ossystems Code Review - openembedded-core.git/commitdiff
package.bbclass: fix directories setuid and setgid bits
authorJoël Esponde <joel.esponde@easymile.com>
Thu, 18 Jul 2019 13:47:39 +0000 (15:47 +0200)
committerArmin Kuster <akuster808@gmail.com>
Wed, 4 Sep 2019 15:21:53 +0000 (08:21 -0700)
populate_packages relies on ``mkdir`` to both create a directory and set
its permissions. However, ``mkdir`` honors the ``umask`` value.
Therefore, some bits may be lost in the operation. In our case, the
setgid bit on the directories were lost.

This commit fixes this by having a distinct call to create the directory
and to set the permissions.

Signed-off-by: Jean-Tiare Le Bigot <jean-tiare.le-bigot@easymile.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
meta/classes/package.bbclass

index 2c44fc1f0d4a802ef0613f09c3b80388c625c51e..472d542b113301eb7b9a8a6ac18eb47892233463 100644 (file)
@@ -1210,7 +1210,8 @@ python populate_packages () {
                 src = os.path.join(src, p)
                 dest = os.path.join(dest, p)
                 fstat = cpath.stat(src)
-                os.mkdir(dest, fstat.st_mode)
+                os.mkdir(dest)
+                os.chmod(dest, fstat.st_mode)
                 os.chown(dest, fstat.st_uid, fstat.st_gid)
                 if p not in seen:
                     seen.append(p)