From: Kevin Hao Date: Wed, 30 Sep 2015 02:29:33 +0000 (+0800) Subject: kernel.bbclass: fix the bug of checking the existing sections in do_strip() X-Git-Tag: 2015-10~171 X-Git-Url: https://code.ossystems.io/gitweb?a=commitdiff_plain;h=4965f122ca67c0ff60dc60f7885db1ed9db909b4;p=openembedded-core.git kernel.bbclass: fix the bug of checking the existing sections in do_strip() Ross reported the following waring when building edgerouter BSP: WARNING: Section not found: .comment The reason is that the testing of the existing sections in do_strip() returned the wrong value. Please see the following code in do_strip(): for str in ${KERNEL_IMAGE_STRIP_EXTRA_SECTIONS}; do { if [ "$headers" != *"$str"* ]; then bbwarn "Section not found: $str"; fi "$CROSS_COMPILE"strip -s -R $str ${KERNEL_OUTPUT} }; done The "*" doesn't have special meaning in the if string test, so it will return true even the $str is a substring of $headers. Fix this issue by replacing it with "! (echo "$headers" | grep -q "^$str$")". Reported-by: Ross Burton Signed-off-by: Kevin Hao Signed-off-by: Ross Burton Signed-off-by: Richard Purdie --- diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass index dfbdfd24ff..5e8b6cf343 100644 --- a/meta/classes/kernel.bbclass +++ b/meta/classes/kernel.bbclass @@ -413,7 +413,7 @@ do_strip() { gawk '{print $1}'` for str in ${KERNEL_IMAGE_STRIP_EXTRA_SECTIONS}; do { - if [ "$headers" != *"$str"* ]; then + if ! (echo "$headers" | grep -q "^$str$"); then bbwarn "Section not found: $str"; fi